Skip to content

feat: Support for Multiple Custom Domains #1113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jul 15, 2025

Conversation

kushalshit27
Copy link
Contributor

@kushalshit27 kushalshit27 commented Jun 16, 2025

🔧 Changes

Example:

customDomains:
  - domain: my_domain.com
    .....................
+    domain_metadata:
+      myKey: value

📌 Note:

  • primary field is deprecated and may be removed in future versions.
  • verification_method field is deprecated and may be removed in future versions.

📚 References

🔬 Testing

  • Unit Test added

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.29%. Comparing base (8f3014c) to head (e55aaae).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1113      +/-   ##
==========================================
+ Coverage   80.27%   80.29%   +0.02%     
==========================================
  Files         131      131              
  Lines        4957     4954       -3     
  Branches      977      976       -1     
==========================================
- Hits         3979     3978       -1     
+ Misses        564      563       -1     
+ Partials      414      413       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kushalshit27 kushalshit27 marked this pull request as ready for review June 16, 2025 12:39
@kushalshit27 kushalshit27 requested a review from a team as a code owner June 16, 2025 12:39
@kushalshit27 kushalshit27 changed the title Support for Multiple Custom Domains feat: Support for Multiple Custom Domains Jun 16, 2025
@kushalshit27 kushalshit27 marked this pull request as draft June 16, 2025 12:49
- Standardize TypeScript ignore comments with proper spacing
- Standardize inline comment formatting with consistent spacing
- Add comprehensive test coverage for custom domain update functionality
@kushalshit27 kushalshit27 marked this pull request as ready for review June 16, 2025 13:26
@kushalshit27 kushalshit27 changed the title feat: Support for Multiple Custom Domains [ Don't merge] feat: Support for Multiple Custom Domains Jun 16, 2025
@kushalshit27 kushalshit27 changed the title [ Don't merge] feat: Support for Multiple Custom Domains [Don't merge] feat: Support for Multiple Custom Domains Jun 16, 2025
@kushalshit27 kushalshit27 requested a review from ramya18101 June 16, 2025 13:29
@kushalshit27 kushalshit27 requested a review from ramya18101 June 18, 2025 06:11
@kushalshit27 kushalshit27 changed the title [Don't merge] feat: Support for Multiple Custom Domains feat: Support for Multiple Custom Domains Jul 14, 2025
@kushalshit27 kushalshit27 merged commit 9aed335 into master Jul 15, 2025
8 checks passed
@kushalshit27 kushalshit27 deleted the DXCDT-1075-mcd-ea-support branch July 15, 2025 03:27
kushalshit27 added a commit that referenced this pull request Jul 15, 2025
@kushalshit27 kushalshit27 mentioned this pull request Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants